The check was trying to use the shell variable $CC instead of the make variable $(CC); it also interpreted grep's return code wrong: 1 means the provided pattern was *not* matched. As a result, pdwtags was never run, not even when building with gcc. Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx> --- src/Makefile.am | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 5794915246..3bf2da543d 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -668,8 +668,7 @@ struct_prefix = ($(libs_prefix)|$(other_prefix)) # which causes the comparison against expected output to fail, so skip # if using clang as CC. PDWTAGS = \ - $(AM_V_GEN)$CC -v 2>&1 | grep -q clang; \ - if test $$? == 1; then \ + $(AM_V_GEN)if $(CC) -v 2>&1 | grep -q clang; then \ echo 'WARNING: skipping pdwtags test with Clang' >&2; \ exit 0; \ fi; \ -- 2.14.3 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
