On Thu, 2018-03-01 at 14:15 +0100, Peter Krempa wrote: > > + <summary> > > + Allow opening secondary drivers > > + </summary> > > + <description> > > + Up until now it was possible to connect to only hypervisor drivers > > + (e.g. qemu:///system, lxc:///, vbox:///system, and so on). The > > + internal drivers (like network driver, node device driver, etc.) were > > + hidden from users and users could use them only indirectly. Starting > > + with this release new connection URIs are accepted. For instance > > + network:///system, storage:///system and so on. > > + </description> > > Isn't this an internal change not really used for consumption of > clients? That's what I thought as well. If so, it's not release notes material. [...] > > + <change> > > + <summary> > > + src: Enable building with GCC 8.0 > > + </summary> > > + <description> > > + GCC 8.0 added more warnings which found some genuine problems with our code. > > + </description> > > I'm not sure whether that improved anything. Also wasn't that gcc 7? No, it was actually GCC 8.0, and there were some actual bugs being found thanks to it. You could maybe move it to the Bug Fixes section, but I'm happy either way. Everything else looks good, so with authorship info and S-o-b fixed Reviewed-by: --help <abologna@xxxxxxxxxx> and safe for freeze. Thanks for accepting to be volunteered for this :) -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
