On Fri, 2018-02-23 at 12:00 +0000, Daniel P. Berrangé wrote:
> Running "make distcheck" ensures that we have CLEANFILES and uninstall
> rules setup correctly, as well as validating VPATH builds succeeed.
>
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
> .travis.yml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/.travis.yml b/.travis.yml
> index 3f26a1eeee..4bdf034829 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -6,8 +6,13 @@ matrix:
> include:
> - compiler: gcc
> dist: precise
> + # Special scenario to run distcheck, so we don't waste time duplicating
> + # work in all the other scenarios. Doesn't work on precise due to the
> + # CVE-2012-3386 flaw being present on that Ubuntu version
> - compiler: gcc
> dist: trusty
> + script:
> + - make -j3 distcheck
> - compiler: clang
> dist: precise
> - compiler: clang
This will override the default script, and make it so the
precise/gcc build only runs distcheck rather than the usual all,
check, syntax-check. So we need something else.
My first idea was to have something like
matrix:
include:
- compiler: gcc
dist: precise
env:
- OS=precise
- compiler: gcc
dist: trusty
env:
- OS=trusty
- compiler: clang
dist: precise
env:
- OS=precise
- compiler: clang
dist: trusty
env:
- OS=trusty
- compiler: clang
os: osx
env:
- OS=macos
script:
- make -j3 && if [ "$OS" != "macos" ]; then make -j3 syntax-check && make -j3 check; fi && if [ "$OS" = "trusty" ]; then make -j3 distcheck; fi
with the new env variable being introduced because, for whatever
reason, Travis defines $TRAVIS_OS_NAME for telling Linux and macOS
apart but no equivalent for telling precise and trusty apart :/
However, I've later realized that precise has already been EOL'd
for almost a year and is already in the process of being (slowly)
decommissioned on Travis too. So I say just rip out the damn
obsolete thing already and move on with our lives :)
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
