On Mon, Feb 26, 2018 at 11:41:16AM +0000, Daniel P. Berrangé wrote: > On Mon, Feb 26, 2018 at 12:20:49PM +0100, Erik Skultety wrote: > > On Mon, Feb 26, 2018 at 11:59:26AM +0100, Michal Privoznik wrote: > > > On 02/25/2018 11:45 PM, Erik Skultety wrote: > > > > Erik Skultety (2): > > > > docs: logos: Remove empty text elements from the banner SVGs > > > > docs: logos: Resize the 'Drop shadow' filter bounding box > > > > > > > > docs/logos/logo-banner-dark.svg | 39 +++++---------------------------------- > > > > docs/logos/logo-banner-light.svg | 39 +++++---------------------------------- > > > > 2 files changed, 10 insertions(+), 68 deletions(-) > > > > > > > > > > > > > ACK and safe for freeze. Don't we need to regenerate PNGs esp. after 2/2? > > > > Well, actually, yes, we should, I'll do that later today, but for a different > > reason - for PNG, you'd normally just resize the canvas if spacing was an issue > > for you, but if you look at the big version of our logo at the webpage from a > > close distance, you can see that the shape of the dropped shadow in the upper > > left corner isn't smooth, in fact, it looks like there's some vertical cut out. > > There's also a little clipping on the top-right corner of the box. I think > this is caused by slight differences in how inkscape and gimp interpret the > SVG file. 'Clipping' - that's the correct terminology I was looking for, thanks. Anyhow, I didn't notice the top-right corner, thanks for pointing that out. > > I used gimp because inkscape created badly antialiased images at the lower > resolutions. I think we might be able to address it by using inkscape to > create a large PNG (eg 2048 pixels), and then use GIMP to resize that large > image to smaller bitmaps. Okay, I'll send a separate series for that and once that's good to go, I'll push it along with this series. Erik -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
