Re: [PATCH v2 06/14] libxl: handle missing switch enum cases

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 20, 2018 at 05:08:14PM +0000, Daniel P. Berrangé wrote:
Cast away enum type for libxl schedular constants since we don't want to

s/schedular/scheduler/

cover all of them and don't want build to break when new ones are added.

Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
---
src/libxl/libxl_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index be11134fb2..4b52de36f5 100644
--- a/src/libxl/libxl_driver.c
+++ b/src/libxl/libxl_driver.c
@@ -4497,7 +4497,7 @@ libxlDomainGetSchedulerType(virDomainPtr dom, int *nparams)

    if (nparams)
        *nparams = 0;
-    switch (sched_id) {
+    switch ((int)sched_id) {

We should get consistent with the spacing after cast and add it to HACKING.
This way I can't tell you to add a space there =)

    case LIBXL_SCHEDULER_SEDF:
        name = "sedf";
        break;
--
2.14.3

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux