Re: [PATCH] nwfilter: assure that virNWFilterSnoop(Eth|Dhcp)Hdr objects don't change size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 19, 2018 at 02:30:19PM -0500, Laine Stump wrote:
> These two objects are used to access fields in actual ethernet packets
> captures with libpcap, so it's essential that they don't change size
> for any reason. This patch uses gnulib's verify() macro to make sure
> their sizes don't change.
> 
> Signed-off-by: Laine Stump <laine@xxxxxxxxx>
> ---
> 
> danpb suggested doing this in his response to my patch fixing virMacAddr:
> 
>   https://www.redhat.com/archives/libvir-list/2018-February/msg00850.html
> 
> I decided to make it a separate patch from the virMacAddr fix.
> 
>  src/nwfilter/nwfilter_dhcpsnoop.c | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux