Re: [PATCH v2 07/15] qemu: Clear out qemuDomainDeviceDefValidateControllerPCI()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2018-02-19 at 10:40 +0100, Peter Krempa wrote:
> > Renaming the function won't work because then the compiler will
> > complain about it being unused. Unless you meant something like
> > 
> >   /* Delete once done */
> >   ValidateControllerPCIOld() {
> >     /* Existing checks here */
> >   }
> > 
> >   ValidateControllerPCI() {
> >     /* New checks here */
> > 
> >     /* Delete once done */
> >     ValidateControllerPCIOld();
> >   }
> > 
> > which could actually do the trick.
> 
> I meant this flow obviously, so that the checks are kept until
> fixed/reimplemented.

It was not obvious to me when reading the first message :)

But I agree it's a better way to handle the situation, so I will
do it this way in v3.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux