On Tue, Feb 13, 2018 at 12:34:54PM -0500, John Ferlan wrote: > > > On 02/09/2018 12:24 PM, Daniel P. Berrangé wrote: > > Rather than expecting callers to pass a virConnectPtr into the > > virDomainDiskTranslateSourcePool() method, just acquire a connection > > to the storage driver when needed. > > > > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> > > --- > > src/conf/domain_conf.c | 10 +++++++--- > > src/conf/domain_conf.h | 3 +-- > > src/qemu/qemu_conf.c | 3 +-- > > src/qemu/qemu_conf.h | 3 +-- > > src/qemu/qemu_driver.c | 39 ++++++++++++++++----------------------- > > src/qemu/qemu_hotplug.c | 2 +- > > src/qemu/qemu_process.c | 4 ++-- > > 7 files changed, 29 insertions(+), 35 deletions(-) > > > > qemuxml2argvtest fails with this patch (turned on VIR_TEST_DEBUG=1) Yeah, I noticed this since posting and am working on a solution to stop us trying to open the real libvirtd connection. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
