In this second version I enable -Wswitch-enum to strongly validate all switches cover all enum cases. Daniel P. Berrangé (3): Turn on -Wswitch-enum and fix all problems it identifies Fix more switch fallthrough identified by gcc8 Disable gcc8 -Wcast-function-type warnings from -Wextra m4/virt-compile-warnings.m4 | 9 ++++-- src/conf/domain_audit.c | 1 + src/conf/domain_conf.c | 47 +++++++++++++++++++++++++++---- src/conf/nwfilter_conf.c | 32 ++++++++++++++++++++- src/esx/esx_driver.c | 1 + src/esx/esx_vi.c | 11 +++++--- src/esx/esx_vi_types.c | 9 +++--- src/hyperv/hyperv_driver.c | 18 ++++++++++-- src/libxl/libxl_driver.c | 2 +- src/lxc/lxc_container.c | 7 +++-- src/lxc/lxc_controller.c | 10 ++++++- src/lxc/lxc_driver.c | 40 +++++++++++++++++++++++--- src/nwfilter/nwfilter_ebiptables_driver.c | 16 +++++++---- src/nwfilter/nwfilter_learnipaddr.c | 6 +++- src/qemu/qemu_command.c | 28 ++++++++++++------ src/qemu/qemu_domain.c | 35 ++++++++++++++++++----- src/qemu/qemu_domain_address.c | 11 ++++++++ src/qemu/qemu_driver.c | 27 ++++++++++++------ src/qemu/qemu_hotplug.c | 36 +++++++++++++++++++---- src/qemu/qemu_migration.c | 11 +++++++- src/qemu/qemu_process.c | 2 ++ src/rpc/virnetclient.c | 2 ++ src/rpc/virnetclientprogram.c | 1 + src/rpc/virnetserverprogram.c | 4 +++ src/security/security_driver.c | 1 + src/util/virconf.c | 13 ++++++++- src/util/virfirewall.c | 7 +++-- src/util/virlog.c | 10 ++++++- src/util/virnetdevvportprofile.c | 11 +++++++- src/vmx/vmx.c | 27 ++++++++++++++++-- src/xenconfig/xen_common.c | 17 +++++++++-- src/xenconfig/xen_xl.c | 8 +++++- tools/virt-host-validate-qemu.c | 3 +- 33 files changed, 389 insertions(+), 74 deletions(-) -- 2.16.1 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list