On 02/12/2018 01:05 PM, Daniel P. Berrangé wrote: > On Mon, Feb 12, 2018 at 12:44:52PM +0100, Martin Kletzander wrote: >> On Thu, Feb 01, 2018 at 09:58:17AM -0500, John Ferlan wrote: >>> >>> >>> On 02/01/2018 09:04 AM, Michal Privoznik wrote: >>>> In 2074ef6cd4a2 and c56cdf259 (and friends) we've added two >>>> attributes to virtio NICs: rx_queue_size and tx_queue_size. >>>> However, sysadmins might want to set these on per-host basis but >>>> don't necessarily have an access to domain XML (e.g. because they >>>> are generated by some other app). So let's expose them under >> >> Define "sysadmins" here. If there's a management app running that >> covers some hosts, then the app is the sysadmin. Who will be setting >> these in the conf file? Some person? Manually? I don't think so. My >> bet is that it will be the same mgmt app that generates the XML. Or the >> same person who deploys the app, but still manually. If that app is >> unable to have a default, then why should libvirt be? > > IIUC, this feature came in as a request to solve a limitation that > exists in OpenStack nova not having support for setting this feature > for guest XML. > > IMHO the right fix for that request is to address the feature gap > in Nova, not add this to libvirt to workaround fact that Nova has > not supported this yet. Agreed. Lets revert the commit. Sorry for the noise. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
