On Thu, Feb 08, 2018 at 02:19:37PM -0500, Laine Stump wrote: > In the no-mac-broadcast test, a ping is sent to 192.168.122.255, but > tcpdump is set to look for packets with a destination IP of > 255.255.255.255. Change it to check for the correct IP address and > also for mac broadcast (which is what the no-mac-broadcast filter > actually looks at). This should eliminate the "false success" that was > happening because tcpdump wasn't actually seeing the broadcast packet > the guest was sending, as well as catching the "false failure" caused > by tcpdump seeing other traffic from the guest unrelated to the test > (which happened to be broadcasts sent to 255.255.255.255). > > Signed-off-by: Laine Stump <laine@xxxxxxxxx> > --- > > Unchanged from V1, it just had no review. > > scripts/nwfilter/230-no-mac-broadcast.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
