Re: [PATCH perl v2] Remove use of Data::Dumper from example programs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 02/06/2018 01:10 PM, Daniel P. Berrangé wrote:
> Using Data::Dumper in examples does not help devs understand the data
> structures that the Perl APIs are returning. Change to explicit field
> accesses to illustrate it better
> 
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
>  examples/dhcp-leases.pl |  7 +++++--
>  examples/dom-fsinfo.pl  |  8 +++-----
>  examples/dom-ifinfo.pl  | 14 +++++++++-----
>  examples/dom-stats.pl   |  9 +++------
>  examples/node-info.pl   | 26 +++++++++++++++++++-------
>  5 files changed, 39 insertions(+), 25 deletions(-)
> 

Changes probably should mention this too..

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux