On Tue, Feb 06, 2018 at 11:18:56 +0100, Viktor Mihajlovski wrote: > Refreshing the halted state can cause VM performance issues. Since > s390 is currently the only architecture with a known interest in > the halted state, we're avoiding to call QEMU on other platforms. > > Signed-off-by: Viktor Mihajlovski <mihajlov@xxxxxxxxxxxxxxxxxx> > --- > src/qemu/qemu_domain.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c > index df433c2..d2c833f 100644 > --- a/src/qemu/qemu_domain.c > +++ b/src/qemu/qemu_domain.c > @@ -8634,6 +8634,10 @@ qemuDomainRefreshVcpuHalted(virQEMUDriverPtr driver, > if (vm->def->virtType == VIR_DOMAIN_VIRT_QEMU) > return 0; > > + /* Only supported on s390(x) */ > + if (!ARCH_IS_S390(vm->def->os.arch)) > + return 0; I think we also should remove the 'halted' field from the stats output if the information was not gathered at all, since it would falsely reply that the cpu is not halted all the time.
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
