Re: [PATCH v2 00/11] Add admin protocol support for virtlogd/virtlockd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 23, 2018 at 13:23:36 +0000, Daniel Berrange wrote:
> The initial admin protocol support was only integrated into libvirtd.
> This series extracts that code so that it is reusable with all the
> daemons we have (and more than we'll get).
> 
> In v2:
> 
>  - Fixed completely broken post-exec restart support for admin servers
>  - Misc fixes from v1 review
> 
> Daniel P. Berrange (11):
>   admin: move admins server impl/dispatch into src/admin directory
>   libvirtd: rename virNetServerClient callback impls to match type names
>   admin: add support for post-exec restart callbacks
>   util: add virGetUNIXSocketPath helper
>   rpc: clarify "void *" values passed to client callbacks
>   rpc: pass virNetServer to post-exec restart callback in typesafe
>     manner
>   rpc: annotate various parameters as being required to be non-NULL
>   rpc: add method for checking if a named server exists
>   rpc: refactor virNetServer setup for post-exec restarts
>   logd: add support for admin protocol in virtlogd
>   lockd: add support for admin protocol in virtlockd

This series (probably) breaks build on my gentoo box:

  CC       util/libvirt_setuid_rpc_client_la-viralloc.lo
  CC       util/libvirt_setuid_rpc_client_la-virarch.lo
In file included from ./rpc/virnetmessage.h:24:0,
                 from ./rpc/virnetserverprogram.h:27,
                 from ./rpc/virnetdaemon.h:33,
                 from admin/admin_server.h:27,
                 from admin/admin_server.c:26:
./rpc/virnetprotocol.h:9:21: fatal error: rpc/rpc.h: No such file or directory
 #include <rpc/rpc.h>
                     ^
compilation terminated.
make[3]: *** [Makefile:9269: admin/libvirt_driver_admin_la-admin_server.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
In file included from admin/admin_protocol.c:7:0:
admin/admin_protocol.h:9:21: fatal error: rpc/rpc.h: No such file or directory
 #include <rpc/rpc.h>
                     ^
compilation terminated.
make[3]: *** [Makefile:9262: admin/libvirt_driver_admin_la-admin_protocol.lo] Error 1
In file included from ./rpc/virnetmessage.h:24:0,
                 from ./rpc/virnetserverprogram.h:27,
                 from admin/admin_server_dispatch.h:26,
                 from admin/admin_server_dispatch.c:28:
./rpc/virnetprotocol.h:9:21: fatal error: rpc/rpc.h: No such file or directory
 #include <rpc/rpc.h>
                     ^
compilation terminated.
make[3]: *** [Makefile:9276: admin/libvirt_driver_admin_la-admin_server_dispatch.lo] Error 1

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux