On Mon, Jan 29, 2018 at 11:58:11AM +0100, Peter Krempa wrote: > On Fri, Jan 26, 2018 at 13:35:27 +0000, Daniel Berrange wrote: > > Currently the secondary drivers can only be used if you have a > > connection to a primary hypervisor driver. This series introduces > > explicit URIs that allow opening a connection that only talks to a > > specific secondary driver. In the future these URIs will resolve to > > individual daemons containing those drivers. > > I'm so glad to see this, it felt awkward to hand off the connection > pointer through massive call chains. > > The only thing I'm afraid of in the future is that once the daemons are > split, if the user has a valid connection pointer, the code may still > fail if it fails to open a secondary connection to e.g. the storage > driver. All this while the original caller already had a valid pointer. Yep, that would be a new failure scenario, but I don't think it is too serious in the greater scheme of all possible things that can go wrong. Most likely problem would be that someone/something failed to start the extra daemons. On most distros this won't be a problem, because systemd socket activation will start then on-demand. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
