On 01/06/2018 12:47 AM, John Ferlan wrote: > Move the SATA controller check from command line building to > controller def validation. This includes copying the SATA > skip check found in qemuBuildSkipController. > > Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx> > --- > src/qemu/qemu_command.c | 6 ------ > src/qemu/qemu_domain.c | 24 +++++++++++++++++++++++- > 2 files changed, 23 insertions(+), 7 deletions(-) > > diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c > index 7a138f921..8c728c654 100644 > --- a/src/qemu/qemu_command.c > +++ b/src/qemu/qemu_command.c > @@ -2700,12 +2700,6 @@ qemuBuildControllerDevStr(const virDomainDef *domainDef, > break; > > case VIR_DOMAIN_CONTROLLER_TYPE_SATA: > - if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_ICH9_AHCI)) { > - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", > - _("SATA is not supported with this " > - "QEMU binary")); > - goto error; > - } > virBufferAsprintf(&buf, "ahci,id=%s", def->info.alias); Again, this falls into the same category of patches as the previous one. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list