On Fri, Jan 19, 2018 at 14:53:09 -0500, John Ferlan wrote: > Add a couple of booleans to mark when there's a dump completion event > waiting and when a dump completed event has been received. > > To ensure the dump completed event from a non memory-only dump doesn't > cause the a dump completed event to be fired, only broadcast if there's > a completion event waiting. I think you can just drop job->dumpCompletion as it doesn't seem to be any useful. You set job->dumpCompleted even if dumpCompletion is false, it's just guarding the broadcast, which is harmless. If you were concerned about DUMP_COMPLETED event being send by some other command than the one we call from qemuDumpToFd, you could just ignore the event if the dump job was running, which you should probably do anyway (see qemuProcessHandleMigration*) to make sure you job->dumpCompleted is not unexpectedly set to true before a dump job starts. Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
