On Thu, Jan 25, 2018 at 09:04:05AM -0500, John Ferlan wrote: > > > On 01/17/2018 12:37 PM, Daniel P. Berrange wrote: > > This wires up the previously added OEM strings XML schema to be able to > > generate comamnd line args for QEMU. This requires QEMU >= 2.12 release > > containing this patch: > > > > commit 2d6dcbf93fb01b4a7f45a93d276d4d74b16392dd > > Author: Daniel P. Berrange <berrange@xxxxxxxxxx> > > Date: Sat Oct 28 21:51:36 2017 +0100 > > > > smbios: support setting OEM strings table > > > > Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx> > > --- > > src/qemu/qemu_command.c | 28 ++++++++++++++++++++++++++++ > > tests/qemuxml2argvdata/smbios.args | 2 ++ > > tests/qemuxml2argvdata/smbios.xml | 5 +++++ > > tests/qemuxml2xmloutdata/smbios.xml | 5 +++++ > > 4 files changed, 40 insertions(+) > > > > Would a QEMU < 2.12 cause a failure if the 'type=11' OEM strings were > provided or do we need to add a capability in virQEMUCapsInitQMPMonitor > based on version? Yes it will $ qemu-system-x86_64 -smbios type=11 qemu-system-x86_64: -smbios type=11: Don't know how to build fields for SMBIOS type 11 Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
