On Wed, Jan 24, 2018 at 14:34:49 +0000, Daniel P. Berrange wrote: ... > I had considered whether we should require a Reviewed-by tags to show > that someone other than the author has reviewed a patch before it is > pushed. It is not practical to check this automatically though, given > that we like the flexibility to be able to push build-breaker fixes > or trivial fixes, etc as-is. So I won't propose making anything else > mandatory - at very most I'd encourage, but *not* require, other tags. Since Signed-off-by is going to be required, automatic check would be doable. After all at some point in the past you mentioned either Signed-off-by from someone with commit access or Reviewed-by could be required. However anyone pushing a patch is either the contributor or is apparently confident of the patch to the extent they could provide Reviewed-by so the condition is implicitly met by the fact the patch was pushed. In other words, having Reviewed-by in the commit message is nice for generating statistics for KVM Forum keynotes, once the patch gets out of our git repository (i.e., is backported to a downstream), or when someone wants to see who the hell could have acked this. But it's not something one couldn't live without. That said, I don't mind if either of these tags are mandatory as both are somewhat useful. Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
