Re: [PATCH v2 1/9] virsh: Introduce virshStoragePoolNameCompleter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 01/24/2018 03:50 AM, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
> 
> Diff to v1:
> - Pruned the list of flags accepted in the callback
> - Pools for vol_* are ACTIVE only
> - Other small nits raised in the review
> 
>  tools/virsh-completer.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
>  tools/virsh-completer.h |  4 ++++
>  tools/virsh-pool.c      | 28 ++++++++++++++--------------
>  tools/virsh-volume.c    | 10 +++++++---
>  tools/virsh.h           |  6 ++++--
>  5 files changed, 77 insertions(+), 19 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux