--- Changes | 4 ++-- HACKING | 4 ++-- lib/Sys/Virt.pm | 6 +++--- lib/Sys/Virt/Domain.pm | 14 +++++++------- lib/Sys/Virt/Interface.pm | 2 +- lib/Sys/Virt/NWFilter.pm | 2 +- lib/Sys/Virt/Network.pm | 4 ++-- lib/Sys/Virt/NodeDevice.pm | 4 ++-- lib/Sys/Virt/Secret.pm | 4 ++-- lib/Sys/Virt/StoragePool.pm | 4 ++-- lib/Sys/Virt/StorageVol.pm | 8 ++++---- lib/Sys/Virt/Stream.pm | 2 +- 12 files changed, 29 insertions(+), 29 deletions(-) diff --git a/Changes b/Changes index 96b42f8..0571cf8 100644 --- a/Changes +++ b/Changes @@ -472,7 +472,7 @@ Revision history for perl module Sys::Virt 0.2.6 2011-02-16 - Fix build with 0.8.7 libvirt by removing reference to - non-existant constant only introduced in libvirt > 0.8.7 + non-existent constant only introduced in libvirt > 0.8.7 - Fix test script when hostname is undefined 0.2.5 2011-02-04 @@ -533,7 +533,7 @@ Revision history for perl module Sys::Virt - Added networking APIs - Added APIs for host capabilities - Added APIs for inactive domains - - Switch licensse to GPLv2+ or Artistic for CPAN compatability + - Switch licensse to GPLv2+ or Artistic for CPAN compatibility - Fix return values for reboot/shutdown/undefine/create APIs - Expanded documentation coverage diff --git a/HACKING b/HACKING index bb8b0f0..bfd1212 100644 --- a/HACKING +++ b/HACKING @@ -15,7 +15,7 @@ Additions to the libvirt C API will require changes to a minimum of two parts of the Sys::Virt codebase. - Virt.xs - this provides the C glue code to access the libvirt C - library APIs and constants from the Perl interpretor. As a general + library APIs and constants from the Perl interpreter. As a general rule, every new function and header file constant/enum requires an addition to this file. The exceptions are functions that are only provided for the benefit of language bindings and not intended for @@ -93,7 +93,7 @@ effective way to update the Perl binding. - For each missing item reported in the test suite... - Edit Virt.xs to add the C binding - - Edit lib/*.pm to add the POD documentation (and occassionally Perl glue code) + - Edit lib/*.pm to add the POD documentation (and occasionally Perl glue code) - Edit Changes to document the addition - Run the test suite (without maintainer mode) to verify POD docs # ../libvirt/run make test diff --git a/lib/Sys/Virt.pm b/lib/Sys/Virt.pm index 2ce7ed5..faaf668 100644 --- a/lib/Sys/Virt.pm +++ b/lib/Sys/Virt.pm @@ -135,7 +135,7 @@ types that will be supported. The credential constants in this module can be used as values in this list. The C<callback> parameter should be a subroutine reference containing the code necessary to gather the credentials. When invoked it -will be supplied with a single parameter, a array reference +will be supplied with a single parameter, an array reference of requested credentials. The elements of the array are hash references, with keys C<type> giving the type of credential, C<prompt> giving a user descriptive user @@ -1164,7 +1164,7 @@ pool sources. =item my @stats = $vmm->get_all_domain_stats($stats, \@doms=undef, $flags=0); -Get an list of all statistics for domains known to the hypervisor. +Get a list of all statistics for domains known to the hypervisor. The C<$stats> parameter controls which data fields to return and should be a combination of the DOMAIN STATS FIELD CONSTANTS. @@ -1469,7 +1469,7 @@ how long the node is suspended for before waking up. =item $conn->domain_event_register($callback) -Register a callback to received notificaitons of domain state change +Register a callback to received notifications of domain state change events. Only a single callback can be registered with each connection instance. The callback will be invoked with four parameters, an instance of C<Sys::Virt> for the connection, an instance of C<Sys::Virt::Domain> diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm index 38b9c9b..7b90b68 100644 --- a/lib/Sys/Virt/Domain.pm +++ b/lib/Sys/Virt/Domain.pm @@ -45,7 +45,7 @@ sub _new { my $class = ref($proto) || $proto; my %params = @_; - my $con = exists $params{connection} ? $params{connection} : die "connection parameter is requried"; + my $con = exists $params{connection} ? $params{connection} : die "connection parameter is required"; my $self; if (exists $params{name}) { $self = Sys::Virt::Domain::_lookup_by_name($con, $params{name}); @@ -490,7 +490,7 @@ One of the CONTROL INFO constants listed later =item C<details> -Currently unsed, always 0. +Currently unused, always 0. =item C<stateTime> @@ -658,7 +658,7 @@ later. =item $dom->detach_device($xml[, $flags]) -Hotunplug a existing device whose configuration is given by C<$xml>, +Hotunplug an existing device whose configuration is given by C<$xml>, from the running guest. The optional <$flags> parameter defaults to 0, but can accept one of the device hotplug flags described later. @@ -1719,7 +1719,7 @@ instead of MB/s. Abort the current job that is executing for the block device associated with C<$path> -=item $dom->block_pull($path, $bandwith, $flags=0) +=item $dom->block_pull($path, $bandwidth, $flags=0) Merge the backing files associated with C<$path> into the top level file. The C<$bandwidth> parameter specifies the @@ -1735,7 +1735,7 @@ instead of MB/s. =back -=item $dom->block_rebase($path, $base, $bandwith, $flags=0) +=item $dom->block_rebase($path, $base, $bandwidth, $flags=0) Switch the backing path associated with C<$path> to instead use C<$base>. The C<$bandwidth> parameter specifies the @@ -1774,7 +1774,7 @@ The maximum amount of data in flight in bytes. =back -=item $dom->block_commit($path, $base, $top, $bandwith, $flags=0) +=item $dom->block_commit($path, $base, $top, $bandwidth, $flags=0) Commit changes there were made to the temporary top level file C<$top>. Takes all the differences between C<$top> and C<$base> and merge them @@ -3827,7 +3827,7 @@ The host storage has run out of free space =item Sys::Virt::Domain::DISK_ERROR_UNSPEC -An unspecified error has ocurred. +An unspecified error has occurred. =back diff --git a/lib/Sys/Virt/Interface.pm b/lib/Sys/Virt/Interface.pm index 58fa2af..8f6112a 100644 --- a/lib/Sys/Virt/Interface.pm +++ b/lib/Sys/Virt/Interface.pm @@ -45,7 +45,7 @@ sub _new { my $class = ref($proto) || $proto; my %params = @_; - my $con = exists $params{connection} ? $params{connection} : die "connection parameter is requried"; + my $con = exists $params{connection} ? $params{connection} : die "connection parameter is required"; my $self; if (exists $params{name}) { $self = Sys::Virt::Interface::_lookup_by_name($con, $params{name}); diff --git a/lib/Sys/Virt/NWFilter.pm b/lib/Sys/Virt/NWFilter.pm index 927b038..8ede8a0 100644 --- a/lib/Sys/Virt/NWFilter.pm +++ b/lib/Sys/Virt/NWFilter.pm @@ -45,7 +45,7 @@ sub _new { my $class = ref($proto) || $proto; my %params = @_; - my $con = exists $params{connection} ? $params{connection} : die "connection parameter is requried"; + my $con = exists $params{connection} ? $params{connection} : die "connection parameter is required"; my $self; if (exists $params{name}) { $self = Sys::Virt::NWFilter::_lookup_by_name($con, $params{name}); diff --git a/lib/Sys/Virt/Network.pm b/lib/Sys/Virt/Network.pm index d90b58b..415e629 100644 --- a/lib/Sys/Virt/Network.pm +++ b/lib/Sys/Virt/Network.pm @@ -45,7 +45,7 @@ sub _new { my $class = ref($proto) || $proto; my %params = @_; - my $con = exists $params{connection} ? $params{connection} : die "connection parameter is requried"; + my $con = exists $params{connection} ? $params{connection} : die "connection parameter is required"; my $self; if (exists $params{name}) { $self = Sys::Virt::Network::_lookup_by_name($con, $params{name}); @@ -363,7 +363,7 @@ Network lifecycle events The following constants allow network lifecycle change events to be interpreted. The events contain both a state change, and a -reason though the reason is currently unsed. +reason though the reason is currently unused. =over 4 diff --git a/lib/Sys/Virt/NodeDevice.pm b/lib/Sys/Virt/NodeDevice.pm index 0539b9e..1ca3fa3 100644 --- a/lib/Sys/Virt/NodeDevice.pm +++ b/lib/Sys/Virt/NodeDevice.pm @@ -47,7 +47,7 @@ sub _new { my $class = ref($proto) || $proto; my %params = @_; - my $con = exists $params{connection} ? $params{connection} : die "connection parameter is requried"; + my $con = exists $params{connection} ? $params{connection} : die "connection parameter is required"; my $self; if (exists $params{name}) { $self = Sys::Virt::NodeDevice::_lookup_by_name($con, $params{name}); @@ -201,7 +201,7 @@ Node device config update events The following constants allow node device lifecycle change events to be interpreted. The events contain both a state change, and a -reason though the reason is currently unsed. +reason though the reason is currently unused. =over 4 diff --git a/lib/Sys/Virt/Secret.pm b/lib/Sys/Virt/Secret.pm index 0c6a021..a5ae9eb 100644 --- a/lib/Sys/Virt/Secret.pm +++ b/lib/Sys/Virt/Secret.pm @@ -45,7 +45,7 @@ sub _new { my $class = ref($proto) || $proto; my %params = @_; - my $con = exists $params{connection} ? $params{connection} : die "connection parameter is requried"; + my $con = exists $params{connection} ? $params{connection} : die "connection parameter is required"; my $self; if (exists $params{usageID} || exists $params{usageType}) { @@ -200,7 +200,7 @@ Secret value change events The following constants allow secret lifecycle change events to be interpreted. The events contain both a state change, and a -reason though the reason is currently unsed. +reason though the reason is currently unused. =over 4 diff --git a/lib/Sys/Virt/StoragePool.pm b/lib/Sys/Virt/StoragePool.pm index f4d5696..3c8abda 100644 --- a/lib/Sys/Virt/StoragePool.pm +++ b/lib/Sys/Virt/StoragePool.pm @@ -47,7 +47,7 @@ sub _new { my $class = ref($proto) || $proto; my %params = @_; - my $con = exists $params{connection} ? $params{connection} : die "connection parameter is requried"; + my $con = exists $params{connection} ? $params{connection} : die "connection parameter is required"; my $self; if (exists $params{name}) { $self = Sys::Virt::StoragePool::_lookup_by_name($con, $params{name}); @@ -496,7 +496,7 @@ Storage pool volume refresh events The following constants allow storage pool lifecycle change events to be interpreted. The events contain both a state change, and a -reason though the reason is currently unsed. +reason though the reason is currently unused. =over 4 diff --git a/lib/Sys/Virt/StorageVol.pm b/lib/Sys/Virt/StorageVol.pm index 82c3df2..917eb82 100644 --- a/lib/Sys/Virt/StorageVol.pm +++ b/lib/Sys/Virt/StorageVol.pm @@ -48,16 +48,16 @@ sub _new { my $self; if (exists $params{name}) { - my $pool = exists $params{pool} ? $params{pool} : die "pool parameter is requried"; + my $pool = exists $params{pool} ? $params{pool} : die "pool parameter is required"; $self = Sys::Virt::StorageVol::_lookup_by_name($pool, $params{name}); } elsif (exists $params{key}) { - my $con = exists $params{connection} ? $params{connection} : die "connection parameter is requried"; + my $con = exists $params{connection} ? $params{connection} : die "connection parameter is required"; $self = Sys::Virt::StorageVol::_lookup_by_key($con, $params{key}); } elsif (exists $params{path}) { - my $con = exists $params{connection} ? $params{connection} : die "connection parameter is requried"; + my $con = exists $params{connection} ? $params{connection} : die "connection parameter is required"; $self = Sys::Virt::StorageVol::_lookup_by_path($con, $params{path}); } elsif (exists $params{xml}) { - my $pool = exists $params{pool} ? $params{pool} : die "pool parameter is requried"; + my $pool = exists $params{pool} ? $params{pool} : die "pool parameter is required"; if ($params{clone}) { $self = Sys::Virt::StorageVol::_create_xml_from($pool, $params{xml}, $params{clone}, 0); } else { diff --git a/lib/Sys/Virt/Stream.pm b/lib/Sys/Virt/Stream.pm index a2fbc2b..9e4855e 100644 --- a/lib/Sys/Virt/Stream.pm +++ b/lib/Sys/Virt/Stream.pm @@ -44,7 +44,7 @@ sub _new { my $class = ref($proto) || $proto; my %params = @_; - my $con = exists $params{connection} ? $params{connection} : die "connection parameter is requried"; + my $con = exists $params{connection} ? $params{connection} : die "connection parameter is required"; my $self = Sys::Virt::Stream::_new_obj($con, $params{flags}); bless $self, $class; -- 2.14.1 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list