Re: [PATCH] vshReadlineOptionsGenerator: Don't add already specified options to the list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 15, 2018 at 10:34:29AM +0100, Michal Privoznik wrote:
> The current state of art is as follows:
>
>  1) vshReadlineOptionsGenerator() generate all possible --options
>  for given command, and then
>  2) vshReadlineOptionsPrune() clears out already provided ones
>  from the list.
>
> Not only this brings needless memory complexity it is also not
> trivial to get right. We can switch to easier approach: just
> don't add already specified --options in the first step.
>
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx>

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux