On Fri, Jan 12, 2018 at 12:31:46PM +0100, Pavel Hrdina wrote: > On Thu, Jan 11, 2018 at 04:43:37PM +0000, Daniel P. Berrange wrote: > > Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx> > > --- > > libvirt-python.spec.in | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx> > > In addition we should rename __python RPM macro to __python2 for fedora > and rhel > 7. This applies to python_sitearch as well. I don't think we should do that (yet) as python_sitearch still works and AFAIK isn't going to be changed to point to the py3 binary. This avoids need for more conditionals. Once RHEL8 comes out and we drop RHEL6 as a target for libvirt, we can do the swtich, since IIUC RHEL-7 has the python2_* macros available. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
