Re: [PATCH 3/4] security, apparmor: add (Set|Restore)ChardevLabel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> +    char *in = NULL, *out = NULL;
>> +    int ret = -1;
>> +
>> +    virSecurityLabelDefPtr secdef = virDomainDefGetSecurityLabelDef(def,
>> +                                                SECURITY_APPARMOR_NAME);
>> +    if (!secdef)
>> +        return 0;
>
> There shouldn't be empty line in variable declaration. However, there
> should be one after the block.
>
> BTW: here and in the function below - if we need to call a function with
> a long name to initialize a variable we usually do that on a separate line.

Yes to both suggestions, thanks!

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux