Re: [PATCH v2 2/2] qemu: Add support for pseries machine's max-cpu-compat= parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2018-01-05 at 19:18 +0530, Shivaprasad G Bhat wrote:
> When the -machine pseries,max-cpu-compat=X is supported use
> machine parameter instead of -cpu host,compat=X parameter as
> that is deprecated now with qemu > v2.10.

That's actually >= 2.10.

> Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1519146
> 
> Signed-off-by: Shivaprasad G Bhat <sbhat@xxxxxxxxxxxxxxxxxx>
> ---
>  src/qemu/qemu_command.c                            |   11 ++++++++++
>  .../pseries-machine-max-cpu-compat.args            |   21 ++++++++++++++++++++
>  .../pseries-machine-max-cpu-compat.xml             |   17 ++++++++++++++++
>  tests/qemuxml2argvtest.c                           |    5 +++++
>  4 files changed, 53 insertions(+), 1 deletion(-)
>  create mode 100644 tests/qemuxml2argvdata/pseries-machine-max-cpu-compat.args
>  create mode 100644 tests/qemuxml2argvdata/pseries-machine-max-cpu-compat.xml

Everything else looks good, so

  Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

I've performed some minor formatting tweaks that wouldn't justify
a full respin, addressed the commit message issue mentioned above
and pushed the series.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux