On Thu, 2018-01-04 at 18:04 +0530, Shivaprasad G Bhat wrote:
> Signed-off-by: Shivaprasad G Bhat <sbhat@xxxxxxxxxxxxxxxxxx>
> ---
> src/qemu/qemu_capabilities.c | 7 +++++++
> src/qemu/qemu_capabilities.h | 2 ++
> tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 1 +
> 3 files changed, 10 insertions(+)
>
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index 9673ef8..fdc8b37 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
[...]
> @@ -4836,6 +4837,12 @@ virQEMUCapsInitQMPMonitor(virQEMUCapsPtr qemuCaps,
> if (qemuCaps->version >= 2010000)
> virQEMUCapsSet(qemuCaps, QEMU_CAPS_NUMA_DIST);
>
> + /* no way to query max-cpu-comapt */
s/comapt/compat/g
> diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
> index e73dbaa..f041324 100644
> --- a/src/qemu/qemu_capabilities.h
> +++ b/src/qemu/qemu_capabilities.h
> @@ -442,6 +442,8 @@ typedef enum {
>
> /* 280 */
> QEMU_CAPS_DEVICE_PL011, /* -device pl011 (not user-instantiable) */
> + QEMU_CAPS_MACHINE_PSERIES_MAX_CPU_COMPAT, /* -machine
> + * pseries,max-cpu-compat=xxx */
You can leave out the 'xxx' part and avoid spreading the comment
over two lines.
With those nits fixed,
Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
