On 01/03/2018 03:46 PM, Peter Krempa wrote: > On Tue, Jan 02, 2018 at 08:09:37 -0500, John Ferlan wrote: >> >> >> On 01/02/2018 04:28 AM, Michal Privoznik wrote: >>> Unfortunately, since gnulib's commit of 2c5d558745 there's an >>> unused parameter to stat_time_normalize() function which gnulib >>> developers don't want to fix [1]. Therefore, we have to work >>> around it by temporarily suspending -Wunused-parameter. >>> >>> 1: http://lists.gnu.org/archive/html/bug-gnulib/2018-01/msg00000.html >>> >>> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> >>> --- >>> >>> While we have 'gnulib update free' push rule, this one is not trivial at >>> all and thus I have not pushed it. It's ugly and I don't like it. So any >>> ideas are welcome. >>> >>> .gnulib | 2 +- >>> bootstrap | 4 ++-- >>> src/storage/storage_util.c | 3 +++ >>> 3 files changed, 6 insertions(+), 3 deletions(-) >>> >> >> >> No bright ideas on this other than perhaps only including changes just >> prior to the particular one that breaks things or somehow revert just >> that one in our local copy. > > How about just killing that stupid syntax check in our local copy? > That wouldn't help either. We could not upgrade to newer gnulib unless it's fixed. But fortunately, it looks like we're close to an agreement how to fix gnulib so we can update it in our repo too. michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
