On Fri, Dec 15, 2017 at 02:53 PM +0100, John Ferlan <jferlan@xxxxxxxxxx> wrote: > On 12/12/2017 06:36 AM, Marc Hartmayer wrote: >> Merge critical sections for virNetServerProcessClients and take the >> lock of @client before we're calling virNetServerClientNeedAuth. This >> is done in preparation for upcoming patches and in addition it is more >> efficient not to release a lock which is reacquired immediately >> afterwards. >> >> Signed-off-by: Marc Hartmayer <mhartmay@xxxxxxxxxxxxxxxxxx> >> Reviewed-by: Boris Fiuczynski <fiuczy@xxxxxxxxxxxxxxxxxx> >> Reviewed-by: Stefan Zimmermann <stzi@xxxxxxxxxxxxxxxxxx> >> --- >> src/libvirt_remote.syms | 3 ++- >> src/rpc/virnetserver.c | 12 ++++++++---- >> src/rpc/virnetserverclient.c | 22 ++++++++++++++-------- >> src/rpc/virnetserverclient.h | 3 ++- >> 4 files changed, 26 insertions(+), 14 deletions(-) >> > > I think if you split out the virNetServerClientIsClosedLocked into its > own patch before/after the virNetServerClientNeedAuthLocked, then > perhaps patch 7 and 9 are combined. Done. > > It's just a patch ordering and trying not to do too much in one patch. > >> diff --git a/src/libvirt_remote.syms b/src/libvirt_remote.syms >> index 3ce5694b781d..efdf912ec563 100644 >> --- a/src/libvirt_remote.syms >> +++ b/src/libvirt_remote.syms […snip] -- Beste Grüße / Kind regards Marc Hartmayer IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
