On 21.12.2017 11:49, Erik Skultety wrote: > On Thu, Dec 21, 2017 at 09:39:16AM +0100, Cedric Bosdonnat wrote: >> Hi John, >> >> On Wed, 2017-12-20 at 16:52 -0500, John Ferlan wrote: >>> So I moved the Unref(dmn) after virStateCleanup... That of course led to >>> the virt-manager issue. So I figured I'd give adding this patch in and >>> that then fixed the virt-manager crash (obviously as we'd be Unref'ing >>> all those servers we added). >> >> Seems like I forgot to git-send my patch yesterday evening: here it is: >> >> https://www.redhat.com/archives/libvir-list/2017-December/msg00739.html >> >> That fixes the virt-manager crash at least. > > Hi, so the patch looks good, at first glance it makes complete sense to close > the client connections when closing the server and unreffing the objects when > disposing of the server object. However, since this and the other related > issues have been bugging us for quite some time I'm not going to say ACK just > yet, I'd like to think about it for a bit - but if someone else already has and > they feel brave enough :P, then I'm not going to block this to go in. > > Erik > Patch looks good to me too. But still original "libvirtd: fix crash on termination" fixes another issue and if applied fixes "virt-manager issue" as well as John figured out. Nikolay -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
