At 2017-12-20 19:49:41, "John Ferlan" <jferlan@xxxxxxxxxx> wrote: >Similar to qemuDomainAddChardevTLSObjects let's move the chardev >source must be TCP and it has the @haveTLS flag set checks before >trying to delete the TLS objects. > >For the Chr device this represents no change; however, for RNG device >this is an additionaly check that was missed in commit id '68808516'. >Before adding the objects, TCP and haveTLS are checked. > >Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx> >--- > > Thanks for the review... Of course after re-reading my own patch "in > the morning" I realized I could/should have taken the next step to check > the chardev source for TCP and haveTLS being set similar to how the Add > code does things. So that's what this patch does. > Ahh, more helpful helper. Reviewed-by: Chen Hanxiao <chenhanxiao@xxxxxxxxx> Regards, - Chen -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
