Re: [PATCH 0/9] Yet another version of CAT stuff (no idea about the version number)

Eli <qiaoliyong@xxxxxxxxx> · Thu, 14 Dec 2017 19:54:57 +0800



     I will
      try to more cases..

      
    Sorry, I forget to limit line word as 80. 

    
    Missing one issue I see:

    
    If the host enabled CDP, which is to see the host will report l3
    cache type

    code and data. when user don't want code/data cache ways allocated

    separated, for current implement, it will report not support `both`
    type

    l3 cache.

    
    But we can improve this as make code and data schemata the same

    e.g, if host enabled CDP, but user request 2 `both` type l3 cache.

    
    We can write the schemata looks like:

    
    L3DATA:0=3

    L3CODE:0=3

    
     Thanks
      Eli.

      
                Martin Kletzander (9):

                  Rename virResctrlInfo to virResctrlInfoPerCache

                  util: Add virResctrlInfo

                  conf: Use virResctrlInfo in capabilities

                  util: Remove now-unneeded resctrl functions

                  resctrl: Add functions to work with resctrl
                allocations

                  conf: Add support for cputune/cachetune

                  tests: Add virresctrltest

                  qemu: Add support for resctrl

                  docs: Add CAT (resctrl) support into news.xml

                
                 docs/formatdomain.html.in       
                                  |   54 +

                 docs/news.xml                                      |   
                9 +

                 docs/schemas/domaincommon.rng                      | 
                 32 +

                 po/POTFILES.in                                     |   
                1 +

                 src/Makefile.am                                    |   
                2 +-

                 src/conf/capabilities.c                            | 
                 55 +-

                 src/conf/capabilities.h                            |   
                4 +-

                 src/conf/domain_conf.c                             | 
                251 ++++

                 src/conf/domain_conf.h                             | 
                 13 +

                 src/libvirt_private.syms                           | 
                 16 +-

                 src/qemu/qemu_process.c                            | 
                 61 +-

                 src/util/virresctrl.c                              |
                1380 ++++++++++++++++++--

                 src/util/virresctrl.h                              | 
                 86 +-

                 src/util/virresctrlpriv.h                          | 
                 27 +

                 tests/Makefile.am                                  |   
                8 +-

                 tests/genericxml2xmlindata/cachetune-cdp.xml     
                 |   36 +

                 .../cachetune-colliding-allocs.xml               
                 |   30 +

                 .../cachetune-colliding-tunes.xml                 
                |   32 +

                 .../cachetune-colliding-types.xml                 
                |   30 +

                 tests/genericxml2xmlindata/cachetune-small.xml   
                 |   29 +

                 tests/genericxml2xmlindata/cachetune.xml         
                 |   33 +

                 tests/genericxml2xmltest.c                         | 
                 10 +

                 tests/virresctrldata/resctrl-cdp.schemata         
                |    2 +

                 .../virresctrldata/resctrl-skx-twocaches.schemata 
                |    1 +

                 tests/virresctrldata/resctrl-skx.schemata         
                |    1 +

                 tests/virresctrldata/resctrl.schemata             
                |    1 +

                 tests/virresctrltest.c                             | 
                102 ++

                 27 files changed, 2174 insertions(+), 132 deletions(-)

                 create mode 100644 src/util/virresctrlpriv.h

                 create mode 100644 tests/genericxml2xmlindata/cachetune-cdp.xml

                 create mode 100644 tests/genericxml2xmlindata/cachetune-colliding-allocs.xml

                 create mode 100644 tests/genericxml2xmlindata/cachetune-colliding-tunes.xml

                 create mode 100644 tests/genericxml2xmlindata/cachetune-colliding-types.xml

                 create mode 100644 tests/genericxml2xmlindata/cachetune-small.xml

                 create mode 100644 tests/genericxml2xmlindata/cachetune.xml

                 create mode 100644 tests/virresctrldata/resctrl-cdp.schemata

                 create mode 100644 tests/virresctrldata/resctrl-skx-twocaches.schemata

                 create mode 100644 tests/virresctrldata/resctrl-skx.schemata

                 create mode 100644 tests/virresctrldata/resctrl.schemata

                 create mode 100644 tests/virresctrltest.c

                
                    --

                    2.15.1

                    
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list