Re: [PATCH 3/3] util: Report error if vhost-scsi device file cannot be found

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 12/12/2017 09:22 AM, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1523564

If the vhost-scsi device file cannot be found, the generic error

     "error: An error occurred, but the cause is unknown"

is returned.  Let's add a real error message to make it clear
why the failure occurred.

Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>

Reviewed-by: Eric Farman <farman@xxxxxxxxxxxxxxxxxx>

---
  src/util/virscsivhost.c | 6 +++++-
  1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/util/virscsivhost.c b/src/util/virscsivhost.c
index d6fbf5ed5..5f176e177 100644
--- a/src/util/virscsivhost.c
+++ b/src/util/virscsivhost.c
@@ -86,8 +86,12 @@ VIR_ONCE_GLOBAL_INIT(virSCSIVHost)
  int
  virSCSIVHostOpenVhostSCSI(int *vhostfd)
  {
-    if (!virFileExists(VHOST_SCSI_DEVICE))
+    if (!virFileExists(VHOST_SCSI_DEVICE)) {
+        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+                       _("vhost-scsi device file '%s' cannot be found"),
+                       VHOST_SCSI_DEVICE);
          return -1;
+    }

      *vhostfd = open(VHOST_SCSI_DEVICE, O_RDWR);


--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux