Re: [PATCH v4 0/3] Move ide validation from qemuBuildControllerDevStr to qemuDomainDeviceDefValidate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 12/03/2017 11:06 PM, Lin Ma wrote:
> Validate IDE controllers in qemuDomainDeviceDefValidate for reminding users earlier.
> 
> v3->v4:
> Drop changes in tests/qemuxml2argvdata/qemuxml2argv-disk-floppy-pseries.args
> Merged patch #3 and #4 for avoiding git bisect failure.
> 
> Lin Ma (3):
>   tests: qemuxml2argv: Use scsi controller instead of ide in pseries
>   tests: qemuhotplugtest: Drop ide controller in ccw
>   qemu_domain: Error out earlier when configuring IDE controller
>     incorrectly
> 

I've encapsulated/incorporated these into a series I've posted that
takes care of more qemu_command controller checks in Validate
functionality.  See patches 5-7 in:

https://www.redhat.com/archives/libvir-list/2017-December/msg00079.html


>  src/qemu/qemu_command.c                            | 17 -----------
>  src/qemu/qemu_domain.c                             | 35 +++++++++++++++++++++-
>  .../qemuhotplug-base-ccw-live+ccw-virtio.xml       |  4 ---
>  ...ive-with-2-ccw-virtio+ccw-virtio-1-explicit.xml |  4 ---
>  ...live-with-2-ccw-virtio+ccw-virtio-1-reverse.xml |  4 ---
>  ...qemuhotplug-base-ccw-live-with-2-ccw-virtio.xml |  4 ---
>  ...-live-with-ccw-virtio+ccw-virtio-2-explicit.xml |  4 ---
>  ...-base-ccw-live-with-ccw-virtio+ccw-virtio-2.xml |  4 ---
>  .../qemuhotplug-base-ccw-live-with-ccw-virtio.xml  |  4 ---
>  .../qemuhotplug-base-ccw-live.xml                  |  4 ---
>  .../qemuxml2argv-disk-floppy-pseries.xml           |  4 +--
>  11 files changed, 36 insertions(+), 52 deletions(-)
> 

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux