On 11/21/2017 03:38 AM, Pavel Hrdina wrote: > On Mon, Nov 20, 2017 at 05:22:48PM -0500, John Ferlan wrote: >> >> >> On 11/14/2017 08:45 AM, Pavel Hrdina wrote: >>> These test cases models current situation where there is no way how >>> to specify sound output and that it's based on which graphic device >>> is the last one. >>> >> >> Personally had a hard time parsing what the commit message said, but >> based on what happens 2 patches from now, I think you're just trying to >> add vm's w/ a sound device. Not so sure it's the "default" sound device >> or just "a" sound device. Not sure how much clearer you could make >> things or if it really matters - I'll leave it up to you to reread and >> be sure what's happening is what you expect! > > Well I'm sure that this patch does what I expect from it :). > > How about this commit message: > > These test cases models current situation where there is no way how s/models/model the/ s/situation/environment/ s/way how/mechanism/ > to specify audio output of sound devices. The audio output is s/audio/the audio/ > currently based on which graphic device is configured as the last > one in domain XML. > > Pavel > Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
