Re: [PATCH 2/3] tools: Set CFLAGS for wireshark properly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 16, 2017 at 02:49:28PM +0100, Michal Privoznik wrote:
> We want to set CFLAGS not CPPFLAGS.
>
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  tools/Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/Makefile.am b/tools/Makefile.am
> index 7513a73ac..a844dcbbc 100644
> --- a/tools/Makefile.am
> +++ b/tools/Makefile.am
> @@ -427,7 +427,7 @@ EXTRA_DIST += \
>  if WITH_WIRESHARK_DISSECTOR
>
>  ws_plugin_LTLIBRARIES = wireshark/src/libvirt.la
> -wireshark_src_libvirt_la_CPPFLAGS = \

CPPFLAGS are flags for preprocessor IIUC but judging from the variable's
content == other CFLAGS, I think this is OK while also being a "no change".

Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx>

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux