Commit messages have either gone on a diet or the writer is on strike On 11/13/2017 03:50 AM, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx> > --- > src/qemu/qemu_process.c | 61 +++++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 56 insertions(+), 5 deletions(-) > This seems reasonable too, Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> John > diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c > index 7df440ee4345..335146ab71b8 100644 > --- a/src/qemu/qemu_process.c > +++ b/src/qemu/qemu_process.c [...] > @@ -6434,6 +6479,12 @@ void qemuProcessStop(virQEMUDriverPtr driver, > vm->def->name); > } > > + /* Remove resctrl allocation after cgroups are cleaned up which makes it > + * kind of safer (although removing the allocation should work even with > + * pids in tasks file */ > + for (i = 0; i < vm->def->ncachetunes; i++) > + virResctrlAllocRemove(vm->def->cachetunes[i]->alloc); > + Oh and here is Stop doing the Remove... Perhaps why earlier since I hadn't read something like this so perhaps why I asked about it before checking consumers of AllocRemove > qemuProcessRemoveDomainStatus(driver, vm); > > /* Remove VNC and Spice ports from port reservation bitmap, but only if > -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
