On 11/13/2017 09:47 AM, Martin Kletzander wrote: > On Fri, Nov 10, 2017 at 04:23:27PM +0100, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1497410 >> >> This reverts commit bc8a99ef06417a2303ccab455f9f045e2a617916. >> >> The vhostuser is not a TAP. Therefore our QoS code is not able to >> set any bandwidth. I don't really understand what I was thinking. >> > > Yeah, brainfart on both sides, I guess. I mean the naming can get > confusing. > We still give socket to the chardev if I'm not mistaken. Also didn't > you mean > the vhost-net instead, that one is a TUN, right? But it's not an interface > type, so we don't need to allow it here. vhost-net is a device under /dev that is a backend for 'virtio' interface model. It is not a TAP device per se. Vhost is a device emulation within KVM (outside of qemu). 'vhost-net' is then an instance for network interfaces. > > ACK with ears prepared for both of us :( Yeah. Luckily we have two pairs of them :-) Pushed, thanks. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
