On 11/06/2017 11:08 AM, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx> > --- > ...qemuxml2argv-pseries-hpt-resizing-disabled.args | 20 ++++++++++++++++ > .../qemuxml2argv-pseries-hpt-resizing-disabled.xml | 19 +++++++++++++++ > .../qemuxml2argv-pseries-hpt-resizing-enabled.args | 20 ++++++++++++++++ > .../qemuxml2argv-pseries-hpt-resizing-enabled.xml | 19 +++++++++++++++ > ...l2argv-pseries-hpt-resizing-invalid-machine.xml | 18 ++++++++++++++ > ...qemuxml2argv-pseries-hpt-resizing-required.args | 20 ++++++++++++++++ > .../qemuxml2argv-pseries-hpt-resizing-required.xml | 19 +++++++++++++++ > tests/qemuxml2argvtest.c | 20 ++++++++++++++++ > ...emuxml2xmlout-pseries-hpt-resizing-disabled.xml | 28 ++++++++++++++++++++++ > ...qemuxml2xmlout-pseries-hpt-resizing-enabled.xml | 28 ++++++++++++++++++++++ > ...emuxml2xmlout-pseries-hpt-resizing-required.xml | 28 ++++++++++++++++++++++ > tests/qemuxml2xmltest.c | 13 ++++++++++ > 12 files changed, 252 insertions(+) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-hpt-resizing-disabled.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-hpt-resizing-disabled.xml > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-hpt-resizing-enabled.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-hpt-resizing-enabled.xml > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-hpt-resizing-invalid-machine.xml > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-hpt-resizing-required.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-hpt-resizing-required.xml > create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-hpt-resizing-disabled.xml > create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-hpt-resizing-enabled.xml > create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-hpt-resizing-required.xml > Those against test bloat would point out only one of the three options is really necessary... IDRC, but I also see the trend that could be started as new things are added that have 10 different options. I'm fine with any one of the 3 to be used... Your call though. Since 'enabled' is used for the without CAPS test and 'resizing' for the wrong machine test, then perhaps 'disabled' should be the one carried through - just a thought as all 3 would then "prove" the ability to parse the 3 options. Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
