On 11/10/2017 03:50 PM, Martin Kletzander wrote: > On Thu, Nov 09, 2017 at 01:43:22PM +0100, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1434451 >> >> When testing user aliases it was discovered that for 440fx >> machine type which has default IDE bus builtin, domain cannot >> start if IDE controller has the user provided alias. This is >> because for 440fx we don't put the IDE controller onto the >> command line (since it is builtin) and therefore any device that >> is plugged onto the bus must use the default alias. >> >> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> >> --- >> src/qemu/qemu_command.c | 14 +++++++++++--- >> tests/qemuxml2argvdata/qemuxml2argv-user-aliases.args | 4 ++-- >> 2 files changed, 13 insertions(+), 5 deletions(-) >> > > Look like that's fine in this case. ACK. Thanks, pushed. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
