On 11/09/2017 07:20 AM, Peter Krempa wrote: > Setup everything related to disks in one place rather than calling in > from various places. > > The change to ordering of the setup steps is necessary since secrets > need the master key to be present. > --- > src/qemu/qemu_domain.c | 5 +---- > src/qemu/qemu_process.c | 14 +++++++++----- > 2 files changed, 10 insertions(+), 9 deletions(-) > > diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c > index db5af1019..fd78e43e3 100644 > --- a/src/qemu/qemu_domain.c > +++ b/src/qemu/qemu_domain.c > @@ -1647,10 +1647,7 @@ qemuDomainSecretPrepare(virConnectPtr conn, > size_t i; > int ret = -1; > > - for (i = 0; i < vm->def->ndisks; i++) { > - if (qemuDomainSecretDiskPrepare(conn, priv, vm->def->disks[i]) < 0) > - goto cleanup; > - } > + /* disk aliases are prepared when preparing disks */ You mean secrets.... John [...] -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list