Re: [PATCH 1/2] docs: Update vbox driver documentation.

[John Ferlan <jferlan@xxxxxxxxxx>]

On 11/07/2017 04:36 PM, Dawid Zamirski wrote:
> * libvirt no longer supports vbox <= 3.x
> * update XML definition sample to show how to attach disks to VBOX's SAS
>   controller and how to change IDE controller model.
> * update XML to show how to create RDP display with autoport.
> ---
>  docs/drvvbox.html.in | 28 +++++++++++++++++++++++++++-
>  1 file changed, 27 insertions(+), 1 deletion(-)
> 
> diff --git a/docs/drvvbox.html.in b/docs/drvvbox.html.in
> index 63f166b24..a56f5db11 100644
> --- a/docs/drvvbox.html.in
> +++ b/docs/drvvbox.html.in
> @@ -5,7 +5,7 @@
>          <h1>VirtualBox hypervisor driver</h1>
>          <p>
>          The libvirt VirtualBox driver can manage any VirtualBox version
> -        from version 2.2 onwards.
> +        from version 4.0 onwards.

Hmmm... we should have changed that as part of commit id '73c6f16ba' or
'ccdf108c'.

Mind if I add a "(<span class="since">since libvirt 3.0.0</span>)" prior
to the end of line?

E.g.:

       The libvirt VirtualBox driver can manage any VirtualBox version
       from version 4.0 onwards
       (<span class="since">since libvirt 3.0.0</span>).

>      </p>
>  
>      <h2><a id="project">Project Links</a></h2>
> @@ -68,6 +68,14 @@ vbox+ssh://user@xxxxxxxxxxx/session  (remote access, SSH tunnelled)
>    &lt;/features&gt;
>  
>    &lt;devices&gt;
> +    &lt;!--Set IDE controller model to PIIX4 (default PIIX3)--&gt;
> +    &lt;controller type='ide' model='piix4'/&gt;
> +
> +    &lt;controller type='scsi' index='0'/&gt;
> +
> +    &lt;!--VirtualBox SAS Controller--&gt;
> +    &lt;controller type='scsi' index='1' model='lsisas1068'/&gt;
> +
>      &lt;disk type='file' device='cdrom'&gt;
>        &lt;source file='/home/user/Downloads/slax-6.0.9.iso'/&gt;
>        &lt;target dev='hdc'/&gt;
> @@ -79,6 +87,19 @@ vbox+ssh://user@xxxxxxxxxxx/session  (remote access, SSH tunnelled)
>        &lt;target dev='hdd'/&gt;
>      &lt;/disk&gt;
>  
> +    &lt;!--Attach to the SCSI controller (index=0, default)--&gt;
> +    &lt;disk type='file' device='disk'&gt;
> +      &lt;source file='/home/user/tmp/vbox2.vdi'/&gt;
> +      &lt;target dev='sda' bus='scsi'/&gt;
> +    &lt;/disk&gt;
> +
> +    &lt;!--Attach to the SAS controller (index=1)--&gt;
> +    &lt;disk type='file' device='disk'&gt;
> +      &lt;source file='/home/user/tmp/vbox3.vdi'/&gt;
> +      &lt;target dev='sda' bus='scsi'/&gt;
> +      &lt;address type='drive' controller='1' bus='0' target='0' unit='0'/&gt;
> +    &lt;/disk&gt;
> +
>      &lt;disk type='file' device='floppy'&gt;
>        &lt;source file='/home/user/tmp/WIN98C.IMG'/&gt;
>        &lt;target dev='fda'/&gt;
> @@ -101,6 +122,11 @@ vbox+ssh://user@xxxxxxxxxxx/session  (remote access, SSH tunnelled)
>        &lt;mac address='56:16:3e:5d:c7:9e'/&gt;
>        &lt;model type='82540eM'/&gt;
>      &lt;/interface&gt;
> +    

There's some extraneous whitespace above as git am so kindly told me:

Applying: docs: Update vbox driver documentation.
.git/rebase-apply/patch:57: trailing whitespace.

warning: 1 line adds whitespace errors.

I will fix up before pushing...

John

> +    &lt;graphics type='desktop'/&gt;
> +
> +    &lt;!--Activate the VRDE server with a port in 3389-3689 range--&gt;
> +    &lt;graphics type='rdp' autoport='yes' multiUser='yes'/&gt;
>  
>      &lt;sound model='sb16'/&gt;
>  
> 

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list