On Fri, Oct 27, 2017 at 10:25:23AM +0200, Michal Privoznik wrote: > On 10/27/2017 03:47 AM, Caoxinhua wrote: > > Yes,In qemuxml2argvtest case, mymain call qemuTestDriverInit to init qemu driver, qemuTestDriverInit call mkdtemp() to init stateDir, so stateDir is randomly. But '-monitor' part of the command line must be a const value. Can I use a const value "/tmp/lib" to instead of random value at qemuxml2argvtest? > > We will have to. Looks like we don't need stateDir nor configDir in the > test anyway. I would suggest '/does-not-exist' so we see a hard fail if we accidentally have something in the test suite that tries to create a file in that dir. Using fixed filenames in /tmp is a big no-no in general. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
