On Thu, Oct 26, 2017 at 12:24 PM +0200, Jiri Denemark <jdenemar@xxxxxxxxxx> wrote:
> On Wed, Oct 25, 2017 at 10:56:51 +0200, Marc Hartmayer wrote:
>> On Fri, Oct 13, 2017 at 08:14 PM +0200, Jiri Denemark <jdenemar@xxxxxxxxxx> wrote:
>> > When a hypervisor marks a CPU model as unusable on the current host, it
>> > may also give us a list of features which prevent the model from being
>> > usable. Storing this list in virDomainCapsCPUModel will help the CPU
>> > driver with creating a host-model CPU configuration.
>> >
>> > Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
>> > Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>
> ...
>> > diff --git a/src/conf/domain_capabilities.h b/src/conf/domain_capabilities.h
>> > index 82183c4524..8c71dec21e 100644
>> > --- a/src/conf/domain_capabilities.h
>> > +++ b/src/conf/domain_capabilities.h
>> > @@ -116,6 +116,7 @@ typedef virDomainCapsCPUModel *virDomainCapsCPUModelPtr;
>> > struct _virDomainCapsCPUModel {
>> > char *name;
>> > virDomainCapsCPUUsable usable;
>> > + char **blockers; /* NULL-terminated list of usability blockers */
>> > };
>>
>> I know this is an "old" thread and already pushed. But I think you have
>> to free the blockers list in virDomainCapsCPUModelsDispose as well. No?
>
> Oops, you're right. I've just sent a patch to fix this. Thanks.
Thanks.
>
> Jirka
>
--
Beste Grüße / Kind regards
Marc Hartmayer
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
