Re: [PATCH 2/2] virt-aa-helper-test: only fails go to stdout by default

[Jamie Strandboge <jamie@xxxxxxxxxxxxx>]

On Thu, 2017-10-26 at 15:22 +0200, Christian Ehrhardt wrote:
> By Default (without -d) the tests will only print Failures.
> So a log should follow general "no message is a good message" style.
> 
> But the testfw checks always emit the skip info to stdout. Instead
> they should use the redirection that is controlled by -d.
> 
> This avoids mesages like the following to clutter the log:
>   Skipping FW AAVMF32 test. Could not find
> /usr/share/AAVMF/AAVMF32_CODE.fd
> 
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@xxxxxxxxxxxxx>
> ---
>  tests/virt-aa-helper-test | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/virt-aa-helper-test b/tests/virt-aa-helper-test
> index e837668..d2a557e 100755
> --- a/tests/virt-aa-helper-test
> +++ b/tests/virt-aa-helper-test
> @@ -155,7 +155,7 @@ testfw() {
>              -e "s,</os>,<loader readonly='yes'
> type='pflash'>$fwpath</loader></os>,g" "$template_xml" > "$test_xml"
>          testme "0" "$title" "-r -u $valid_uuid" "$test_xml"
>      else
> -        echo "Skipping FW $title test. Could not find $fwpath"
> +        echo "Skipping FW $title test. Could not find $fwpath"
> >$output
>      fi
>  }

LGTM. Thanks!

-- 
Jamie Strandboge             | http://www.canonical.com

Attachment: signature.asc
Description: This is a digitally signed message part

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list