On Tue, Oct 24, 2017 at 09:51:31AM +0200, Peter Krempa wrote: > Commit fdeac7a05fdf85458d72e89efcfa0f444525aaad tried to fix the output > of 'virsh --help domxml-to-native' by switching types around. One of the > changes broke the option parser. VSH_OT_ARGV should be used only for > variable argument count, not to make the help generator look pretty. > > The correct option type in this case is VSH_OT_STRING as it's not > mandatory now since it can be substituted by using --domain. > > This makes --help for this command look incorrect, but the parser works > as it should. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1494400 > --- > tools/virsh-domain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
