Re: [PATCH] util: Missing 'removeTimeoutImpl' check variable inside virEventRegisterImpl() function.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 10/19/2017 11:35 AM, Julio Faracco wrote:
> The function virEventRegisterImpl() checks the attempt to replace the
> registered events. But there is a duplicate variable inside the IF statement.
> The variable 'removeHandleImpl' was wrongly repeated. One of them needs to be
> replaced by 'removeTimeoutImpl'.
> 
> Signed-off-by: Julio Faracco <jcfaracco@xxxxxxxxx>
> ---
>  src/util/virevent.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Introduced by commit id '5f5c515bb'

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

will push shortly...

Tks,

John

> diff --git a/src/util/virevent.c b/src/util/virevent.c
> index 51d8714..87069e3 100644
> --- a/src/util/virevent.c
> +++ b/src/util/virevent.c
> @@ -241,7 +241,7 @@ void virEventRegisterImpl(virEventAddHandleFunc addHandle,
>                addTimeout, updateTimeout, removeTimeout);
>  
>      if (addHandleImpl || updateHandleImpl || removeHandleImpl ||
> -        addTimeoutImpl || updateTimeoutImpl || removeHandleImpl) {
> +        addTimeoutImpl || updateTimeoutImpl || removeTimeoutImpl) {
>          VIR_WARN("Ignoring attempt to replace registered event loop");
>          return;
>      }
> 

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux