On 10/19/2017 11:55 AM, Martin Kletzander wrote: > On Thu, Oct 19, 2017 at 10:10:56AM +0200, Michal Privoznik wrote: >> This function is not changing passed domain definition. >> Therefore, mark the argument as 'const'. >> > > Is there any other reason for this then just your new code using const? > I don't see any pointer that's passed through your later code that would > be const nowadays, so why would we play the const-correctness game here > when it doesn't make much sense in C when the pointer is to a struct > since the const doesn't propagate? > > If s/const virDomainDeviceDef/virDomainDeviceDef/ on your later patch > makes this one unnecessary, then NACK to this. If there is a reason, > however, feel free to keep this in. Well, later in 08/14 I am indeed calling this from function which takes const virDomainDeviceDef * and I can change it to virDomainDeviceDefPtr. And while I think this patch still makes things better (solves const correctness), I don't want it to be show stopper. Thus I'm dropping it. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
