On 18.10.2017 14:17, John Ferlan wrote: > [...] > >> So I can split this patch to 2 and clear servers hash table as you >> suggusted instead of tossing virThreadPoolFree and add 2 extra >> patches to make referencing at virNetDaemonAddServerPostExec straight. >> This will take almost no time thus let's move to the other parts of the series. >> >> Nikolay >> > > As I said originally I wasn't considering the StateShutdown part of this > series. Post that separately, but be sure to properly state what the > purpose is. I think there is one sentence from the patch1 commit Ok. > message. It doesn't seem that it would avoid a crash on its own. When I > first took a quick look I wondered what the difference with that new > state was and the stateStop functionality - then I noted stateStop > functionality in daemon/libvirtd.c was gated on WITH_DBUS, but that's > about as far as I got to thinking about adding a new state and its > usefulness or purpose. stateShutdown does not really introduces a state. It just helps to terminate state driver. Nikolay -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
