On 10/06/2017 02:47 AM, Ladi Prosek wrote: > Hyper-V uses its own specific memory management so no mapping is going to > be perfect. However, it is more correct to map Limit to max_memory (it > really is the upper limit of what the VM may potentially use) and keep > cur_balloon equal to total_memory. > > The typical value returned from Hyper-V in Limit is 1 TiB, which is not > really going to work if interpreted as "startup memory" to be ballooned > away later. > > Signed-off-by: Ladi Prosek <lprosek@xxxxxxxxxx> > --- > src/hyperv/hyperv_driver.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > Seems reasonable... This was created this way by commit id '5e3b0f8b5' before any of the interceding work to memory size adjustments total_memory/max_balloon and max_memory. Still it would seem that the initial code should have set max_memory to Limit and max_balloon to the cur_balloon value Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
