Ah, top-posting... So OK, we can change this. But if it is used only for master.aes and monitor.sock, then there should not be that many places to be changed. It is also super-easy to find mistakes by just building libvirt. Still, the point about qemuSetPrivatePathsOld() stands, that must not change due to back-compatibility. > Ah , you are right. Old libvirt version doesn't save libDir at runtime domain xml. so that musn't change at function qemuSetPrivatePathsOld. -----邮件原件----- 发件人: Martin Kletzander [mailto:mkletzan@xxxxxxxxxx] 发送时间: 2017年10月13日 18:24 收件人: Caoxinhua 抄送: Daniel P. Berrange; Huangweidong (C); weifuqiang; libvir-list@xxxxxxxxxx; Yanqiangjun; Wangjing (King, Euler) 主题: Re: 答复: [PATCH] qemu: change monitor.sock from /var/lib/libvirt/qemu/domain-*** to /var/run/libvirt/qemu/domain-*** On Fri, Oct 13, 2017 at 08:56:30AM +0000, Caoxinhua wrote: >I also want to change priv->libDir name to priv->runDir. But this might relate a lot of file change. >Currently priv->libDir only save monitor.sock and master-key.aes. All those file need clear at system reset. >So it make sense to change priv->libDir from /var/lib/libvirt/qemu to >/var/run/libvirt/qemu > Ah, top-posting... So OK, we can change this. But if it is used only for master.aes and monitor.sock, then there should not be that many places to be changed. It is also super-easy to find mistakes by just building libvirt. Still, the point about qemuSetPrivatePathsOld() stands, that must not change due to back-compatibility. >-----邮件原件----- >发件人: Daniel P. Berrange [mailto:berrange@xxxxxxxxxx] >发送时间: 2017年10月13日 16:52 >收件人: Martin Kletzander >抄送: Caoxinhua; Huangweidong (C); weifuqiang; libvir-list@xxxxxxxxxx; >Yanqiangjun; Wangjing (King, Euler) >主题: Re: [PATCH] qemu: change monitor.sock from >/var/lib/libvirt/qemu/domain-*** to /var/run/libvirt/qemu/domain-*** > >On Fri, Oct 13, 2017 at 09:21:45AM +0200, Martin Kletzander wrote: >> On Fri, Oct 13, 2017 at 11:36:52AM +0800, xinhua.Cao wrote: >> > directory /var/lib alway is Persistence directory, but in redhat system, /var/run is memory directory. >> > our running domain xml is saved at /var/run/libvirt/qemu. so if we >> > cold reset system, the /var/run/libvirt/qemu directory is clear, >> > but >> > /var/lib/libvirt/qemu/domain-*** is saved. so there have same /var/run/libvirt/qemu/domain-*** directory will be left over at system cold reset. >> >> Is that he only problem? I know it sounds right to have that in a >> runtime directory, but for me it would also make sense to have that >> in a persistent directory. Either this or any other file that >> suggests we did not clean up a domain yet. I'm not sure we are >> currently doing it or that it's a reason for why libDir was chosen, but it might have been. > >libDir is almost certainly just a historical accident. Conceptually runDir makes more sense since this requires no storage across reboots. > >Regards, >Daniel >-- >|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| >|: https://libvirt.org -o- https://fstop138.berrange.com :| >|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
